Various simplifcations around chain handling#6008
Merged
Conversation
lutter
force-pushed
the
lutter/chain-validator
branch
from
ece6366 to
1f21893
Compare
mangas
reviewed
May 27, 2025
server/index-node/src/resolver.rs
Outdated
| return Ok(r::Value::Null); | ||
| }; | ||
| let chain_store = chain.chain_store(); | ||
| // let chain_store = chain.chain_store(); |
mangas
approved these changes
May 27, 2025
It's the only chain impl that actually uses it
It's not needed
It is only used for ethereum, so there's not point in pretending that other chains could be using it.
lutter
force-pushed
the
lutter/chain-validator
branch
from
1f21893 to
ca30fd1
Compare
mangas
approved these changes
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.